@jensenojs I think this breaks certain functionality like toasts

I merged it then reverted it, I should've just checked out ur branch tbh

@jensenojs I think this breaks certain functionality like toasts

Do you mean the notification message? I will look at this issue more carefully tomorrow. Do I need to submit another PR request? @rekram1-node

@jensenojs I can try taking a look at it too, but yeah the toast notifications that pop up in top right seem hidden now. That's the only thing I noticed break

actually wait maybe it is working. I may have been dumb.

your changes work, I unreverted my revert. Sorry for any confusion

that's ok, but do i miss sth? @rekram1-node

ab07229

@jensenojs sorry meant to comment here again, had to revert it againn because:

we're using the theme.background for text in some places like in the select dialog
so when we made it none those lost visibility
i guess we have to introduce textInvert to the theme?
unless there's a different color that already works

@jensenojs sorry meant to comment here again, had to revert it againn because:

we're using the theme.background for text in some places like in the select dialog so when we made it none those lost visibility i guess we have to introduce textInvert to the theme? unless there's a different color that already works

I'm not sure if I've caught up; I understand that this issue needs to be fixed first.

• Unreadable text on selected list when "background": "none" #4369

this seems like it would involve a slightly larger amount of changes because it involve modifying existing themes

yep that’s the related issue